Is this good OOP? :: PHP :: Discussion Forum :: Networks

Networks » Discussion Forum » PHP » Is this good OOP?

JavaScript is not enabled on your browser and in order to properly use Coder Profile JavaScript is required.
To view instructions on how to enable JavaScript on your browser click here.

Posted: 179 Days Ago

Dice
Australia

Contrib Level: 5
Total Posts: 163

Hey guys,

I've decided to learn OOP and what a better way then to write your own CMS. So anyways after some tutorials and playing around with OOP along with xdebug (most awesome debugging tool, honestly I only use it because the errors are colorful and aren't boring) I've come up with some code. This code checks the environment the php script is running in. Can you guys critique my OOP coding style? Thanks.

The Beloved Code:

CODE: index.php	Copy / Restore :: Remove Scroll Bars
function __autoload($class_name) { require_once 'lib/class.' . $class_name . '.php'; } $init = new init; $init->envCheck(); if ($init->getEnvErrors()) echo implode(',', $init->getEnvErrors());

CODE: class.init.php

Copy / Restore

class init {
private $envErrors;
public function envCheck () {
if (ini_get('register_globals') == 1) {
self::setEnvError('register_globals');
}
if(get_magic_quotes_gpc()) {
self::setEnvError('magicquotes');
}
}
private function setEnvError($error) {
$this->envErrors[] = $error;
}
public function getEnvErrors() {
return $this->envErrors;
}
}

Thanks guys

Reply With Quote

Posted: 154 Days Ago

Helbom
Norway

Contrib Level: 1
Total Posts: 1

I'm not a guru in OOP, but from what I know, there's nothing wrong with the way you're doing this :)

Reply With Quote

Posted: 153 Days Ago

VBAssassin
United Kingdom

Contrib Level: 17
Total Posts: 5,709

Your better off starting with something simple... such as using proper objects... not init

Example... a shopping cart...

A shopping cart contains items... which in turn must have a price, title and description... so... to enforce that using OOP you need the following:

An abstract class for the item... which contains the methods: get_price, get_description, get_title... then any item such as a book would extend the abstract item class... this then enforces that those methods exist.

Then you need a shopping cart class... this class needs a method like this: add_item(item $item);

Notice the type hint... this means that when an object is passed to the shopping cart, it will ONLY ACCEPT items that extend the abstract item class. This ensures it gets the correct items and it knows that those 3 methods exist: get_price, get_description, get_title.

Since the shopping cart uses the items... it should be done using aggregation because once you delete the shopping cart... then items should still exist

I would write the code.... but really dont have the time.

Kind regards,
Scott

Reply With Quote

Page 1 of 1